feat: enrich wallet get calls status error info#7568
Draft
Conversation
72762ec to
1ab9592
Compare
1ab9592 to
cc7eab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change?
Currently, when
wallet_getCallsStatusreturnsstatusCode: 500(REVERTED), the response only includes the status code without any error context. The transaction controller may have error information available (message, code, RPC details) but it's not being surfaced in the API response, making it difficult for developers to debug why transactions failed.What is the solution your changes offer and how does it work?
This PR adds an optional
errorfield to thewallet_getCallsStatusresponse whenstatusCode: 500. The implementation extracts error information fromtransaction.error(message, code, name, rpc) when available, and provides a default "Transaction reverted" message when error details aren't present. The error field is only included for REVERTED status, ensuring backward compatibility.References
Checklist